refactor part 1

server/celestial.mjs

@@ -190,24 +190,39 @@ export function getCelestialCurrent(lat, lon, date = new Date()) {
   }
 }
 
-export function getCelestialHourly(lat, lon, hours) {
-  return hours.map(({ time }) => {
-    const d = new Date(time)
-    const pos   = sunPosition(lat, lon, d)
+export function getCelestialHourly(lat, lon, startISO, endISO) {
+  const start = new Date(startISO)
+  const end = new Date(endISO)
+  const results = []
+
+  for (let d = new Date(start); d <= end; d = new Date(d.getTime() + 3600000)) {
+    const pos = sunPosition(lat, lon, d)
     const phase = moonPhase(d)
-    return { time, ...pos, moon_illumination_pct: phase.moon_illumination_pct, moon_phase: phase.moon_phase }
-  })
+    results.push({
+      time: d.toISOString(),
+      ...pos,
+      moon_illumination_pct: phase.moon_illumination_pct,
+      moon_phase: phase.moon_phase
+    })
+  }
+
+  return results
 }
 
-export function getCelestialDaily(lat, lon, days) {
-  return days.map(({ time }) => {
-    const d = new Date(time)
-    return {
-      time,
+export function getCelestialDaily(lat, lon, startISO, endISO) {
+  const start = new Date(startISO)
+  const end = new Date(endISO)
+  const results = []
+
+  for (let d = new Date(start); d <= end; d = new Date(d.getTime() + 86400000)) {
+    results.push({
+      time: d.toISOString(),
       ...sunriseSunset(lat, lon, d),
       ...moonPhase(d),
       ...nextMoonEvents(d),
       ...moonriseMoonset(lat, lon, d),
-    }
-  })
+    })
+  }
+
+  return results
 }