Compare commits

...

1 Commits

Author SHA1 Message Date
2240c93db5 Fixed path events
All checks were successful
Build / Publish Docs (push) Successful in 48s
Build / Build NPM Project (push) Successful in 1m6s
Build / Tag Version (push) Successful in 9s
2025-11-29 20:03:45 -05:00
3 changed files with 26 additions and 38 deletions

View File

@@ -1,6 +1,6 @@
{ {
"name": "@ztimson/utils", "name": "@ztimson/utils",
"version": "0.27.13", "version": "0.27.14",
"description": "Utility library", "description": "Utility library",
"author": "Zak Timson", "author": "Zak Timson",
"license": "MIT", "license": "MIT",

View File

@@ -110,7 +110,7 @@ export class PathEvent {
} }
// Check cache first // Check cache first
if (PathEvent.pathEventCache.has(e)) { if(PathEvent.pathEventCache.has(e)) {
Object.assign(this, PathEvent.pathEventCache.get(e)!); Object.assign(this, PathEvent.pathEventCache.get(e)!);
return; return;
} }
@@ -119,25 +119,13 @@ export class PathEvent {
if(!method) method = '*'; if(!method) method = '*';
// Handle special cases // Handle special cases
if(p === '' || p === undefined) { if(p === '' || p === undefined || p === '*') {
// Empty string matches nothing // Empty string with methods (e.g., ":*") matches the root level/everything
this.module = '';
this.path = '';
this.fullPath = '';
this.name = '';
this.methods = new ASet<Method>(['n']);
this.hasGlob = false;
PathEvent.pathEventCache.set(e, this);
return;
}
if(p === '*') {
// Wildcard means any path any event
this.module = ''; this.module = '';
this.path = ''; this.path = '';
this.fullPath = '**'; this.fullPath = '**';
this.name = ''; this.name = '';
this.methods = new ASet<Method>(['*']); this.methods = new ASet<Method>(p === '*' ? ['*'] : <any>method.split(''));
this.hasGlob = true; this.hasGlob = true;
PathEvent.pathEventCache.set(e, this); PathEvent.pathEventCache.set(e, this);
return; return;
@@ -174,7 +162,7 @@ export class PathEvent {
* @private * @private
*/ */
private static scoreSpecificity(path: string): number { private static scoreSpecificity(path: string): number {
if (path === '**' || path === '') return Number.MAX_SAFE_INTEGER; // Least specific if(path === '**' || path === '') return Number.MAX_SAFE_INTEGER; // Least specific
const segments = path.split('/').filter(p => !!p); const segments = path.split('/').filter(p => !!p);
// Base score: number of segments (more segments = more specific = lower score) // Base score: number of segments (more segments = more specific = lower score)
@@ -183,8 +171,8 @@ export class PathEvent {
// Penalty for wildcards (makes them less specific than exact matches) // Penalty for wildcards (makes them less specific than exact matches)
// ADD to score to make it HIGHER/WORSE // ADD to score to make it HIGHER/WORSE
segments.forEach(seg => { segments.forEach(seg => {
if (seg === '**') score += 0.5; if(seg === '**') score += 0.5;
else if (seg === '*') score += 0.25; else if(seg === '*') score += 0.25;
}); });
return score; return score;
@@ -196,7 +184,7 @@ export class PathEvent {
*/ */
private static pathMatchesGlob(path: string, pattern: string): boolean { private static pathMatchesGlob(path: string, pattern: string): boolean {
// Handle exact match // Handle exact match
if (pattern === path) return true; if(pattern === path) return true;
const pathParts = path.split('/').filter(p => !!p); const pathParts = path.split('/').filter(p => !!p);
const patternParts = pattern.split('/').filter(p => !!p); const patternParts = pattern.split('/').filter(p => !!p);
@@ -207,28 +195,28 @@ export class PathEvent {
while (patternIdx < patternParts.length && pathIdx < pathParts.length) { while (patternIdx < patternParts.length && pathIdx < pathParts.length) {
const patternPart = patternParts[patternIdx]; const patternPart = patternParts[patternIdx];
if (patternPart === '**') { if(patternPart === '**') {
// ** matches zero or more path segments // ** matches zero or more path segments
if (patternIdx === patternParts.length - 1) { if(patternIdx === patternParts.length - 1) {
// ** at the end matches everything // ** at the end matches everything
return true; return true;
} }
// Try matching from next pattern part onwards // Try matching from next pattern part onwards
const nextPattern = patternParts[patternIdx + 1]; const nextPattern = patternParts[patternIdx + 1];
while (pathIdx < pathParts.length) { while (pathIdx < pathParts.length) {
if (PathEvent.pathMatchesGlob(pathParts.slice(pathIdx).join('/'), patternParts.slice(patternIdx + 1).join('/'))) { if(PathEvent.pathMatchesGlob(pathParts.slice(pathIdx).join('/'), patternParts.slice(patternIdx + 1).join('/'))) {
return true; return true;
} }
pathIdx++; pathIdx++;
} }
return false; return false;
} else if (patternPart === '*') { } else if(patternPart === '*') {
// * matches exactly one segment // * matches exactly one segment
pathIdx++; pathIdx++;
patternIdx++; patternIdx++;
} else { } else {
// Exact match required // Exact match required
if (patternPart !== pathParts[pathIdx]) { if(patternPart !== pathParts[pathIdx]) {
return false; return false;
} }
pathIdx++; pathIdx++;
@@ -237,7 +225,7 @@ export class PathEvent {
} }
// Check if we've consumed all pattern parts // Check if we've consumed all pattern parts
if (patternIdx < patternParts.length) { if(patternIdx < patternParts.length) {
// Remaining pattern parts must all be ** to match // Remaining pattern parts must all be ** to match
return patternParts.slice(patternIdx).every(p => p === '**'); return patternParts.slice(patternIdx).every(p => p === '**');
} }
@@ -265,13 +253,13 @@ export class PathEvent {
let result: PathEvent | null = null; let result: PathEvent | null = null;
for (const p of sorted) { for (const p of sorted) {
if (!result) { if(!result) {
result = p; result = p;
} else { } else {
// Only combine if current result's path starts with or matches the new permission's path // Only combine if current result's path starts with or matches the new permission's path
if (result.fullPath.startsWith(p.fullPath)) { if(result.fullPath.startsWith(p.fullPath)) {
// If we hit a none at a parent level, stop here // If we hit a none at a parent level, stop here
if (p.none) { if(p.none) {
break; break;
} }
// Combine methods for permissions in the same hierarchy // Combine methods for permissions in the same hierarchy
@@ -302,20 +290,21 @@ export class PathEvent {
*/ */
private static matches(pattern: PathEvent, target: PathEvent): boolean { private static matches(pattern: PathEvent, target: PathEvent): boolean {
// Handle special cases // Handle special cases
if (pattern.fullPath === '' || target.fullPath === '') return false; if(pattern.fullPath === '' || target.fullPath === '') return false;
if (pattern.fullPath === '*' || target.fullPath === '*') return pattern.methods.has('*') || target.methods.has('*') || pattern.methods.intersection(target.methods).length > 0; if(pattern.fullPath === '**') return pattern.methods.has('*') || pattern.methods.intersection(target.methods).length > 0;
if(target.fullPath === '**') return pattern.methods.has('*') || target.methods.has('*') || pattern.methods.intersection(target.methods).length > 0;
// Check methods // Check methods
const methodsMatch = pattern.all || target.all || pattern.methods.intersection(target.methods).length > 0; const methodsMatch = pattern.all || target.all || pattern.methods.intersection(target.methods).length > 0;
if (!methodsMatch) return false; if(!methodsMatch) return false;
// Check paths // Check paths
if (!pattern.hasGlob && !target.hasGlob) { if(!pattern.hasGlob && !target.hasGlob) {
// Fast path: no globs, use string comparison // Fast path: no globs, use string comparison
return pattern.fullPath === target.fullPath; return pattern.fullPath === target.fullPath;
} }
if (pattern.hasGlob) { if(pattern.hasGlob) {
// Pattern has glob, match target against it // Pattern has glob, match target against it
return this.pathMatchesGlob(target.fullPath, pattern.fullPath); return this.pathMatchesGlob(target.fullPath, pattern.fullPath);
} }

View File

@@ -48,10 +48,9 @@ describe('Path Events', () => {
expect(pe.hasAll('module:c', 'some/path:ud')).toBeTruthy(); expect(pe.hasAll('module:c', 'some/path:ud')).toBeTruthy();
}); });
it('parses empty string as none', () => { it('parses empty string as wildcard', () => {
const pe = new PathEvent(''); const pe = new PathEvent('');
expect(pe.none).toBe(true); expect(pe.has('any/path:c')).toBe(true);
expect(pe.fullPath).toBe('');
}); });
it('parses none method', () => { it('parses none method', () => {