From ea97a26d5c551e81892a6cab68e4ace1005eacb9 Mon Sep 17 00:00:00 2001
From: ztimson <zaktimson@gmail.com>
Date: Wed, 4 Mar 2026 12:20:34 -0500
Subject: [PATCH] fixed cron

---
 backup.sh     | 4 ++--
 entrypoint.sh | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/backup.sh b/backup.sh
index 6caa28b..d4155b0 100644
--- a/backup.sh
+++ b/backup.sh
@@ -6,12 +6,12 @@ TEMP_DUMP="/tmp/mongo_dump_${TIMESTAMP}"
 
 # Create & zip backup
 mkdir -p "$BACKUP_DIR"
-mongodump --host localhost --db "$MONGO_INITDB_DATABASE" -u "$MONGO_INITDB_ROOT_USERNAME" -p "$MONGO_INITDB_ROOT_USERNAME" --out "$TEMP_DUMP"
+mongodump --host localhost --db "$MONGO_INITDB_DATABASE" -u "$MONGO_INITDB_ROOT_USERNAME" -p "$MONGO_INITDB_ROOT_PASSWORD" --out "$TEMP_DUMP"
 tar -czf "${BACKUP_DIR}/${BACKUP_FILE}" -C "$TEMP_DUMP" .
 rm -rf "$TEMP_DUMP"
 
 # Remove old backups
 if [[ -n "$BACKUP_RETENTION" ]]; then
 	cd "$BACKUP_DIR"
-	ls -1t dump_${MONGO_INITDB_DATABASE}_*.tar.gz | tail -n +$((BACKUP_RETENTION + 1)) | xargs -r rm -f
+	ls -1t ${MONGO_INITDB_DATABASE}_*.dump.tar.gz 2>/dev/null | tail -n +$((BACKUP_RETENTION + 1)) | xargs -r rm -f
 fi
diff --git a/entrypoint.sh b/entrypoint.sh
index eb6aeaf..c0b3d0c 100644
--- a/entrypoint.sh
+++ b/entrypoint.sh
@@ -2,10 +2,11 @@
 
 # Setup cron job if BACKUP_CRON is set
 if [ -n "$BACKUP_CRON" ]; then
-    echo "$BACKUP_CRON /usr/local/bin/backup.sh >> /var/log/mongo-backup.log 2>&1" > /etc/cron.d/mongo-backup
+    echo "$BACKUP_CRON /usr/local/bin/backup >> /var/log/mongo-backup.log 2>&1" > /etc/cron.d/mongo-backup
+	echo "" >> /etc/cron.d/mongo-backup
     chmod 0644 /etc/cron.d/mongo-backup
     crontab /etc/cron.d/mongo-backup
-    cron
+    cron &
 fi
 
 # Execute original mongo entrypoint