Merge pull request 'review-labels' (#14) from review-labels into master

Reviewed-on: #14

.github/issue_template/ai-refinement.md

@@ -8,46 +8,12 @@ labels:
 
 ---
 
-# [Module] - [Add/Change/Fix/Refactor/Remove] [Feature/Component]
+Describe your request:
 
-## Type: [Bug/DevOps/Enhancement/Refactor/Security]
+What are you trying to do and what's happening?
 
-|            | Score    |
-|------------|----------|
-| Size       | 0-5      |
-| Complexity | 0-5      |
-| Unknowns   | 0-5      |
-| **Total**  | **0-15** |
+How can it be fixed or improved?
 
-## Description
+Steps to reproduce?
 
-A clear explanation of the issue, feature, or change needed
-
-## Current Behavior
-
-For bugs: what's happening now
-For refactors: what exists today
-For enhancements: current state/gap
-
-## Expected Behavior
-
-What should happen instead
-
-## Steps to Reproduce
-
-1. First step
-2. Second step
-3. Third step
-
-## Additional Context
-
-Logs, screenshots, links, related issues
-
-## Acceptance Criteria
-
-- [ ] Todo requirement
-- [X] Completed requirement
-
-## Technical Notes
-
-Implementation details, constraints, dependencies, design decisions
+Any other useful information? Logs, screenshots, steps to reproduce?

.github/pull_request_template.md

@@ -9,7 +9,5 @@
 
 ## Checklist
 <!-- Complete after creating PR -->
- - [ ] Linked issues
- - [ ] Reviewed changes
+ - [ ] Reviewed changes (or use `Review/AI` label)
  - [ ] Updated comments/documentation
- 

.github/workflows/code-review.yml

@@ -2,7 +2,7 @@ name: Code review
 
 on:
     pull_request:
-        types: [opened, synchronize, reopened]
+        types: [opened, synchronize, reopened, labeled]
 
 jobs:
     review:
@@ -16,7 +16,7 @@ jobs:
                   git fetch origin ${{ github.event.pull_request.base.ref }}
 
             - name: Run AI Review
-              run: npx -y @ztimson/ai-agents@latest review
+              run: npx -y -p @ztimson/ai-agents@latest review $GITHUB_WORKSPACE
               env:
                   AI_HOST: anthropic
                   AI_MODEL: claude-sonnet-4-5

.github/workflows/ticket-refinement.yml

@@ -2,7 +2,8 @@ name: Ticket refinement
 
 on:
     issues:
-        types: [opened, labeled]
+        types: [labeled]
+
 jobs:
     format:
         runs-on: ubuntu-latest
@@ -14,7 +15,7 @@ jobs:
                   git checkout ${{ github.event.repository.default_branch }}
 
             - name: Run AI Formatter
-              run: npx -y @ztimson/ai-agents@latest refine .github/issue_template/ai-refinement.md
+              run: npx -y -p @ztimson/ai-agents@latest refine
               env:
                   AI_HOST: anthropic
                   AI_MODEL: claude-sonnet-4-5

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ztimson/ai-agents",
-	"version": "0.0.4",
+	"version": "0.1.2",
 	"description": "AI agents",
 	"keywords": ["ai", "review"],
 	"author": "ztimson",

src/refine.mjs

@@ -6,16 +6,14 @@ import * as dotenv from 'dotenv';
 import * as fs from 'node:fs';
 import * as path from 'node:path';
 
-dotenv.config({quiet: true});
-dotenv.config({path: '.env.local', override: true, quiet: true});
+dotenv.config({quiet: true, debug: false});
+dotenv.config({path: '.env.local', override: true, quiet: true, debug: false});
 
 (async () => {
 	let p = process.argv[process.argv.length - 1];
 	if(p === 'refine' || p.endsWith('refine.mjs')) p = null;
 	if(!/^(\/|[A-Z]:)/m.test(p)) p = path.join(process.cwd(), p);
 
-	if(!p || !fs.existsSync(p)) throw new Error('Please provide a template');
-
 	const git = process.env['GIT_HOST'],
 		owner = process.env['GIT_OWNER'],
 		repo = process.env['GIT_REPO'],
@@ -23,25 +21,72 @@ dotenv.config({path: '.env.local', override: true, quiet: true});
 		ticket = process.env['TICKET'],
 		host = process.env['AI_HOST'],
 		model = process.env['AI_MODEL'],
+		labelDupe = process.env['LABELS_DUPE'] || 'Review/Duplicate',
+		labelEnabled = process.env['LABEL_ENABLED'] || 'Review/AI',
+		labelsReq = process.env['LABELS_REQ'] || 'Kind/Aesthetic,Kind/Bug,Kind/DevOps,Kind/Document,Kind/Enhancement,Kind/Refactor,Kind/Security',
+		labelsOpt = process.env['LABELS_OPT'] || 'Breaking,Priority,QA',
 		token = process.env['AI_TOKEN'];
 
 	console.log(`Processing issue #${ticket}`);
 
 	// Fetch issue
-	const issueRes = await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}`, {
+	const issueData = await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}`, {
 		headers: {'Authorization': `token ${auth}`}
+	}).then(async resp => {
+		if(resp.ok) return  resp.json();
+		else throw new Error(`${resp.status} ${await resp.text()}`);
 	});
-	if(!issueRes.ok) throw new Error(`${issueRes.status} ${await issueRes.text()}`);
-	const issueData = await issueRes.json();
-	if(!issueData.labels?.some(l => l.name === 'Review/AI')) {
+	if(issueData.labels?.length !== 1 || issueData.labels[0]?.name !== labelEnabled) {
 		console.log('Skipping');
 		return process.exit();
 	}
 
-	let readme = '', readmeP = path.join(process.cwd(), 'README.md');
+	// Gather readme & template
+	let title = '', labels = [], readme = '', readmeP = path.join(process.cwd(), 'README.md');
 	if(fs.existsSync(readmeP)) readme = fs.readFileSync(readmeP, 'utf-8');
-	const template = fs.readFileSync(p, 'utf-8');
+	const template = p ? fs.readFileSync(p, 'utf-8') : `## Description
 
+A clear explanation of the request
+
+---
+
+## Current Behavior
+
+what's happening now or the current state/gap
+
+## Expected Behavior
+
+What should happen instead
+
+## Steps to Reproduce / Desired Flow
+
+1. First step
+2. Second step
+3. Third step
+
+## Additional Context
+
+Logs, screenshots, links, related issues
+
+## Acceptance Criteria
+
+- [ ] Todo requirement
+- [X] Completed requirement
+
+## Technical Notes
+
+Implementation details, constraints, dependencies, design decisions
+
+
+| Effort / Weight | Score    |
+|-----------------|----------|
+| Size            | 0-5      |
+| Complexity      | 0-5      |
+| Unknowns        | 0-5      |
+| **Total**       | **0-15** |
+`;
+
+	// Create AI
 	let options = {ollama: {model, host}};
 	if(host === 'anthropic') options = {anthropic: {model, token}};
 	else if(host === 'openai') options = {openAi: {model, token}};
@@ -49,28 +94,58 @@ dotenv.config({path: '.env.local', override: true, quiet: true});
 		...options,
 		model: [host, model],
 		path: process.env['path'] || os.tmpdir(),
-		system: `You are a ticket formatter. Transform raw issue descriptions into structured tickets.
+		tools: [{
+			name: 'title',
+			description: 'Set the ticket title, must be called EXACTLY ONCE',
+			args: {title: {type: 'string', description: 'Ticket title, must match format: Module - Verb noun', required: true}},
+			fn: (args) => title = args.title
+		}, {
+			name: 'add_label',
+			description: 'Add a label to the ticket',
+			args: {label: {type: 'string', description: 'Label name', required: true}},
+			fn: async (args) => {
+				labels.push(args.label);
+				return await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}/labels`, {
+					method: 'POST',
+					headers: {'Authorization': `token ${auth}`, 'Content-Type': 'application/json'},
+					body: `{"labels":["${args.label}"]}`
+				}).then(async resp => { if(!resp.ok) throw new Error(`${resp.status} ${await resp.text()}`); });
+			}
+		}],
+		system: `Transform raw tickets into structured markdown following the template EXACTLY.
 
-**CRITICAL RULES:**
-1. Identify the ticket type (Bug, DevOps, Enhancement, Refactor, Security)
-2. Output MUST only contain the new ticket information in markdown, no extra fluff
-3. Follow the template structure EXACTLY:
-   - Title format: [Module] - [Verb] [noun]
-     Example: Storage - Fix file uploads
-   - Fill in the identified ticket type
-   - Write a clear description
-   - For bugs: fill Steps to Reproduce with numbered list
-   - For enhancements/refactors: REMOVE the Steps to Reproduce section entirely
-   - Acceptance Criteria: convert requirements into checkboxes (- [ ])
-   - Weight scoring (0-5 each):
-     * Size: Number of modules, layers & files affected by change
-     * Complexity: Technical difficulty to implement
-     * Unknowns: Research/uncertainty in work estimation
-     * Calculate Total as sum of the three
-   - Remove sections that are not applicable based on ticket type
-   - Use proper markdown headers (##)
+**MANDATORY STEPS:**
+1. Call \`title\` tool EXACTLY ONCE in format: "[Module] - [Verb] [subject]" (example: Storage - fix file uploads)
+2. Identify one label from each group which best applies to the ticket: ${labelsReq.replaceAll(',', ', ')}
+3. Call the \`add_label\` tool ONCE FOR EVERY LABEL identified in the previous step
+4. Filter the following labels to any that apply to this ticket: ${labelsOpt.replaceAll(',', ', ')}
+5. Call the \`add_label\` tool ONCE FOR EVERY LABEL identified in the previous step
+6. Output the new ticket description in formatted markdown matching the following rules:
 
-**README:**
+**TEMPLATE RULES:**
+- Use ## headers (match template exactly)
+- Description: Clear summary of the request
+- Current Behavior: What's happening now (remove for Document tickets)
+- Expected Behavior: What should happen (remove for Document tickets)
+- Steps to Reproduce: Numbered list for bugs, flow for enhancements, remove if not applicable
+- Additional Context: Logs, screenshots, links provided by user
+- Acceptance Criteria: Convert to checkboxes (- [ ] format)
+- Technical Notes: Implementation approach, constraints, dependencies
+- Weight table (use exact format below):
+
+| Effort / Weight | Score    |
+|-----------------|----------|
+| Size            | 0-5      |
+| Complexity      | 0-5      |
+| Unknowns        | 0-5      |
+| **Total**       | **0-15** |
+
+**SCORING:**
+- Size: # of modules/layers/files affected
+- Complexity: Technical difficulty
+- Unknowns: Research/uncertainty needed
+
+**PROJECT README:**
 \`\`\`markdown
 ${readme.trim() || 'No README available'}
 \`\`\`
@@ -80,31 +155,63 @@ ${readme.trim() || 'No README available'}
 ${template.trim()}
 \`\`\`
 
-Output ONLY the formatted ticket, no explanation.`
-	})
+Output ONLY markdown. No explanations, labels, or extra formatting.`});
 
+	// Format ticket with AI
 	const messages = await ai.language.ask(`Title: ${issueData.title}\n\nDescription:\n${issueData.body || 'No description provided'}`).catch(() => []);
-	const content = messages?.pop()?.content;
-	if(!content) {
-		console.log('Invalid response from AI');
-		return process.exit(1);
-	}
-	const title = /^# (.+)$/m.exec(content)?.[1] || issueData.title;
-	const typeMatch = /^## Type:\s*(.+)$/m.exec(content);
-	const type = typeMatch?.[1]?.split('/')[0]?.trim() || 'Unassigned';
-	const body = content.replace(/^# .+$/m, '').replace(/^## Type:.+$/m, '').trim();
-	const updateRes = await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}`, {
-		method: 'PATCH',
-		headers: {
-			'Authorization': `token ${auth}`,
-			'Content-Type': 'application/json'
-		},
+	const body = messages?.pop()?.content;
+	if(!body) throw new Error('Invalid response from AI');
+
+	// Check for duplicates
+	const repoInfo = await fetch(`${git}/api/v1/repos/${owner}/${repo}`, {headers: {'Authorization': `token ${auth}`},}).then(resp => resp.ok ? resp.json() : null);
+	const search = await fetch(`${git}/api/v1/repos/issues/search`, {
+		method: 'POST',
+		headers: {'Authorization': `token ${auth}`, 'Content-Type': 'application/json'},
 		body: JSON.stringify({
-			title,
-			body,
-			labels: type?.length ? [`Kind/${type[0].toUpperCase() + type.slice(1).toLowerCase()}`] : []
+			owner,
+			priority_repo_id: repoInfo.id,
+			type: 'issues',
+			limit: 3,
+			q: title
 		})
-	});
-	if(!updateRes.ok) throw new Error(`${updateRes.status} ${await updateRes.text()}`);
-	console.log(body);
-})();
+	}).then(resp => resp.ok ? resp.json() : []);
+	let dupeId = null;
+	const dupeIds = search.map(t => t.id);
+	const dupes = search.map(t => `ID: ${t.id}\nTitle: ${t.title}\n\`\`\`markdown\n${t.body}\n\`\`\``).join('\n\n');
+	const hasDuplicates = (await ai.language.ask(`ID: ${issueData.id}\nTitle: ${title}\n\`\`\`markdown\n${body}\n\`\`\``, {
+		system: `Your job is to identify duplicates. Respond ONLY with the duplicate's ID number or "NONE" if no match exists\n\n${dupes}`
+	}))?.pop()?.content;
+
+	// Handle duplicates
+	if(hasDuplicates && !hasDuplicates.toUpperCase().includes('NONE') && (dupeId = dupeIds.find(id => id == hasDuplicates.trim())) != null && dupeId != issueData.id) {
+		await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}/comments`, {
+			method: 'POST',
+			headers: {'Authorization': `token ${auth}`, 'Content-Type': 'application/json'},
+			body: `{"body": "Duplicate of #${dupeId}"}`
+		}).then(async resp => { if(!resp.ok) throw new Error(`${resp.status} ${await resp.text()}`); });
+		await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}/labels`, {
+			method: 'POST',
+			headers: {'Authorization': `token ${auth}`, 'Content-Type': 'application/json'},
+			body: `{"labels":["${labelDupe}"]}`
+		}).then(async resp => { if(!resp.ok) throw new Error(`${resp.status} ${await resp.text()}`); });
+		await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}`, {
+			method: 'PATCH',
+			headers: {'Authorization': `token ${auth}`, 'Content-Type': 'application/json'},
+			body: '{"state": "closed"}'
+		}).then(async resp => { if(!resp.ok) throw new Error(`${resp.status} ${await resp.text()}`); });
+		console.log('Duplicate');
+		return process.exit();
+	}
+
+	// Update ticket
+	await fetch(`${git}/api/v1/repos/${owner}/${repo}/issues/${ticket}`, {
+		method: 'PATCH',
+		headers: {'Authorization': `token ${auth}`, 'Content-Type': 'application/json'},
+		body: JSON.stringify({title, body})
+	}).then(async resp => { if(!resp.ok) throw new Error(`${resp.status} ${await resp.text()}`); });
+
+	console.log(`Title: ${title}\nLabels: ${labels.join(', ')}\nBody:\n${body}`);
+})().catch(err => {
+	console.error(`Error: ${err.message || err.toString()}`);
+	process.exit(1);
+});

src/review.mjs

@@ -19,12 +19,23 @@ dotenv.config({path: '.env.local', override: true, quiet: true, debug: false});
 		owner = process.env['GIT_OWNER'],
 		repo = process.env['GIT_REPO'],
 		auth = process.env['GIT_TOKEN'],
+		labelEnabled = process.env['LABEL_ENABLED'] || 'Review/AI',
 		pr = process.env['PULL_REQUEST'],
 		host = process.env['AI_HOST'],
 		model = process.env['AI_MODEL'],
 		token = process.env['AI_TOKEN'];
 
 	console.log(`Reviewing: ${root}\n`);
+	const info = await fetch(`${git}/api/v1/repos/${owner}/${repo}/pulls/${pr}`)
+		.then(async resp => {
+			if(resp.ok) return resp.json();
+			throw new Error(`${resp.status} ${await resp.text()}`);
+		});
+	if(!info.labels.some(l => l.name === labelEnabled)) {
+		console.log('Skipping');
+		return process.exit();
+	}
+
 	const branch = process.env['GIT_BRANCH'] || await $`cd ${root} && git symbolic-ref refs/remotes/origin/HEAD`;
 	const comments = [];
 	const commit = await $`cd ${root} && git log -1 --pretty=format:%H`;
@@ -43,7 +54,7 @@ dotenv.config({path: '.env.local', override: true, quiet: true, debug: false});
 		const comments = await Promise.all(reviews.map(r => fetch(`${git}/api/v1/repos/${owner}/${repo}/pulls/${pr}/reviews/${r.id}/comments`, {
 			headers: {'Authorization': `token ${auth}`}
 		}).then(resp => resp.ok ? resp.json() : [])));
-		existingComments += comments.flatten().map(c => `${c.path}:${c.position}\n${c.body}`).join('\n\n');
+		existingComments += comments.flat().map(c => `${c.path}:${c.position}\n${c.body}`).join('\n\n');
 	}
 
 	let options = {ollama: {model, host}};
@@ -53,7 +64,7 @@ dotenv.config({path: '.env.local', override: true, quiet: true, debug: false});
 		...options,
 		model: [host, model],
 		path: process.env['path'] || os.tmpdir(),
-		system: `You are a code reviewer. Analyze the git diff and use the \`recommend\` tool for EACH issue you find. You must call \`recommend\` exactly once for every bug or improvement opportunity directly related to changes. Ignore formatting recommendations. After making all recommendations, provide some concluding remarks about the overall state of the changes.${existingComments}`,
+		system: `You are a code reviewer. Analyze the git diff and use the \`recommend\` tool for EACH issue you find. You must call \`recommend\` exactly once for every bug or improvement opportunity directly related to changes. Ignore formatting recommendations. After making all recommendations, provide a quick 75 words or less sitrep.${existingComments}`,
 		tools: [{
 			name: 'read_file',
 			description: 'Read contents of a file',
@@ -87,7 +98,16 @@ dotenv.config({path: '.env.local', override: true, quiet: true, debug: false});
 		}]
 	});
 
-	const messages = await ai.language.ask(gitDiff);
+	const messages = await ai.language.ask(`Title: ${info.title || 'None'}
+Description:
+\`\`\`md
+${info.body || 'None'}
+\`\`\`
+
+Git Diff:
+\`\`\`
+${gitDiff}
+\`\`\``);
 	const summary = messages.pop().content;
 	if(git) {
 		const res = await fetch(`${git}/api/v1/repos/${owner}/${repo}/pulls/${pr}/reviews`, {
@@ -106,4 +126,7 @@ dotenv.config({path: '.env.local', override: true, quiet: true, debug: false});
 		if(!res.ok) throw new Error(`${res.status} ${await res.text()}`);
 	}
 	console.log(comments.map(c => `${c.path}${c.new_position ? `:${c.new_position}` : ''}\n${c.body}`).join('\n\n') + '\n\n' + summary);
-})();
+})().catch(err => {
+	console.error(`Error: ${err.message || err.toString()}`);
+	process.exit(1);
+});